r-labs

There is some incompatibility between Redmine 2.1.2 and Code review 0.5.0. I discovered this in a test installation where code review is the single plugin. When entering project/settings and selecting code review module it raises Internal error after pressing Save button. Then when returning back with 'back' button of the browser and deselecting code review module, internal error disappears...

Started GET "/projects/first/settings" for 192.168.2.100 at Fri Oct 05 04:50:38 +0300 2012
Processing by ProjectsController#settings as HTML
  Parameters: {"id"=>"first"}
  Current user: admin (id=1)
  Rendered projects/_form.html.erb (125.0ms)
  Rendered projects/_edit.html.erb (218.8ms)
  Rendered projects/settings/_modules.html.erb (15.6ms)
  Rendered projects/settings/_members.html.erb (171.9ms)
  Rendered projects/settings/_versions.html.erb (578.1ms)
  Rendered projects/settings/_issue_categories.html.erb (15.6ms)
  Rendered projects/settings/_repositories.html.erb (31.2ms)
  Rendered projects/settings/_boards.html.erb (15.6ms)
  Rendered projects/settings/_activities.html.erb (750.0ms)
  Rendered plugins/redmine_code_review/app/views/code_review_settings/_filters.html.erb (265.6ms)
  Rendered plugins/redmine_code_review/app/views/code_review_settings/_show.html.erb (546.9ms)
  Rendered common/_tabs.html.erb (2921.9ms)
  Rendered projects/settings.html.erb within layouts/base (2968.8ms)
Completed 500 Internal Server Error in 4172ms

ActionView::Template::Error (undefined method `button_to_remote' for #<#<Class:0x60895c8>:0x636d3f8>):
    99:           <td><%= text_field_tag('auto_assign_add_filter[expression]', '', :size => 60)%>
    100:           </td>
    101:           <td></td>
    102:           <td style="white-space: nowrap;">
    103:             <%= button_to_remote(l(:button_apply), :url => {:controller => 'code_review_settings', :action => '
add_filter', :id => @project},
    104:               :update => 'auto_assignment_filters', :submit => 'code_review_form', :condition => "is_valid_expr
ession($('auto_assign_add_filter_expression'))") %>
    105:             <%= button_to_function(l(:button_cancel), "$('add_filter_form').style.display = 'none'") %>
  app/helpers/application_helper.rb:980:in `labelled_form_for'
  app/views/common/_tabs.html.erb:24:in `_app_views_common__tabs_html_erb___67924633_51912792'
  app/views/common/_tabs.html.erb:23:in `each'
  app/views/common/_tabs.html.erb:23:in `_app_views_common__tabs_html_erb___67924633_51912792'
  app/helpers/application_helper.rb:261:in `render_tabs'
  app/views/projects/settings.html.erb:3:in `_app_views_projects_settings_html_erb___868889321_52035816'

Started GET "/projects/corn/settings/modules" for 192.168.2.100 at Fri Oct 05 05:02:32 +0300 2012
Processing by ProjectsController#settings as HTML
  Parameters: {"id"=>"corn", "tab"=>"modules"}
  Current user: admin (id=1)
  Rendered projects/_form.html.erb (359.4ms)
  Rendered projects/_edit.html.erb (406.2ms)
  Rendered projects/settings/_modules.html.erb (15.6ms)
  Rendered projects/settings/_members.html.erb (15.6ms)
  Rendered projects/settings/_versions.html.erb (15.6ms)
  Rendered projects/settings/_issue_categories.html.erb (0.0ms)
  Rendered projects/settings/_wiki.html.erb (15.6ms)
  Rendered projects/settings/_repositories.html.erb (0.0ms)
  Rendered projects/settings/_boards.html.erb (15.6ms)
  Rendered projects/settings/_activities.html.erb (15.6ms)
  Rendered plugins/redmine_code_review/app/views/code_review_settings/_filters.html.erb (296.9ms)
  Rendered plugins/redmine_code_review/app/views/code_review_settings/_show.html.erb (328.1ms)
  Rendered common/_tabs.html.erb (906.2ms)
  Rendered projects/settings.html.erb within layouts/base (921.9ms)
Completed 500 Internal Server Error in 1297ms

ActionView::Template::Error (undefined method `button_to_remote' for #<#<Class:0x66a6db8>:0x5da7e98>):
    99:           <td><%= text_field_tag('auto_assign_add_filter[expression]', '', :size => 60)%>
    100:           </td>
    101:           <td></td>
    102:           <td style="white-space: nowrap;">
    103:             <%= button_to_remote(l(:button_apply), :url => {:controller => 'code_review_settings', :action => '
add_filter', :id => @project},
    104:               :update => 'auto_assignment_filters', :submit => 'code_review_form', :condition => "is_valid_expr
ession($('auto_assign_add_filter_expression'))") %>
    105:             <%= button_to_function(l(:button_cancel), "$('add_filter_form').style.display = 'none'") %>
  app/helpers/application_helper.rb:980:in `labelled_form_for'
  app/views/common/_tabs.html.erb:24:in `_app_views_common__tabs_html_erb___67924633_50614752'
  app/views/common/_tabs.html.erb:23:in `each'
  app/views/common/_tabs.html.erb:23:in `_app_views_common__tabs_html_erb___67924633_50614752'
  app/helpers/application_helper.rb:261:in `render_tabs'
  app/views/projects/settings.html.erb:3:in `_app_views_projects_settings_html_erb___868889321_50633616'