Defect #258

Error when trying to annotate a file

Added by Arnaud Fontaine about 2 years ago. Updated about 2 years ago.

Status:終了（Closed） Start date:11/27/2009
Priority:通常（Normal） Due date:
Assignee:Haru Iida % Done:

100%
Category:- Spent time: -
Target version:0.2.9.2

Description

Hello,

When trying to annotate a line of a file, I get the following error:

Showing layouts/base.rhtml where line #66 raised:
undefined method `[]' for nil:NilClass

Here is the trace:

vendor/plugins/redmine_code_review/lib/code_review_application_hooks.rb:154:in `change_revision_view'
vendor/plugins/redmine_code_review/lib/code_review_application_hooks.rb:90:in `view_layouts_base_body_bottom'
lib/redmine/hook.rb:63:in `send'
lib/redmine/hook.rb:63:in `call_hook'
lib/redmine/hook.rb:63:in `each'
lib/redmine/hook.rb:63:in `call_hook'
vendor/rails/activesupport/lib/active_support/core_ext/object/misc.rb:28:in `returning'
lib/redmine/hook.rb:60:in `call_hook'
lib/redmine/hook.rb:144:in `call_hook'

An the parameters:

{"rev"=>"77658c010fc873346b596d6fa9a9c5aff85e62b",
"id"=>"test-schedules"}

I have submitted a small patch addressing this issue. Hope that helps.

Regards,
Arnaud Fontaine

redmine_code_review_fix_annotate_empty_changeset.patch - Patch (470 Bytes) Arnaud Fontaine, 11/27/2009 08:54 am

Issue Extensions

Associated revisions

Revision 244:f37585bdaf10
Added by Haru Iida about 2 years ago

fixes #258. Error when trying to annotate a file.

History

#1
Updated by Haru Iida about 2 years ago

  • Status changed from 新規（New） to 担当（Assigned）
  • Assignee set to Haru Iida
  • Target version set to 0.3.0

Hi Arnaud Fontaine,

Thanks for your patch.

#2
Updated by Haru Iida about 2 years ago

  • Status changed from 担当（Assigned） to 解決（Resolved）
  • % Done changed from 0 to 100

チェンジセット r396 で適用されました。

#3
Updated by Haru Iida about 2 years ago

  • Target version changed from 0.3.0 to 0.2.9.2

#4
Updated by Haru Iida about 2 years ago

  • Status changed from 解決（Resolved） to 終了（Closed）

Also available in: Atom PDF