Code Review #420
reek の指摘に従い、リファクタリング
| Status: | 終了（Closed） | Start date: | 06/01/2010 | |
|---|---|---|---|---|
| Priority: | 通常（Normal） | Due date: | ||
| Assignee: |  Takashi Takebayashi |
% Done: | 100% |
|
| Category: | - | Spent time: | 1.00 hour | |
| Target version: | 0.0.6 | Estimated time: | 1.00 hour |
Description
test/unit/joel_test_score_test.rb -- 7 warnings:
JoelTestScoreTest#test_is_joel_test_scores_should_equal calls joel_test_scores(:joel_test_scores001) twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_equal calls joel_test_scores(:joel_test_scores001).user_id twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_equal calls joel_test_scores(:joel_test_scores003) twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_equal has approx 7 statements (LongMethod)
JoelTestScoreTest#test_is_joel_test_scores_should_equal has the variable name 'user1' (UncommunicativeName)
JoelTestScoreTest#test_is_joel_test_scores_should_return_not_nil calls joel_test_scores(:joel_test_scores001) twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_return_not_nil calls joel_test_scores(:joel_test_scores001).user_id twice (Duplication)
Associated revisions
fixes #420
単体テストのリファクタリング
fixes #420
単体テスト等のリファクタリング
fixes #420
単体テスト等のリファクタリング
refs #420
単体テストの追加&リファクタリング
refs #420
関数と単体テストのリファクタリング
History
Updated by Takashi Takebayashi over 1 year ago
- Status changed from 担当（Assigned） to 終了（Closed）
- % Done changed from 0 to 100
- Estimated time set to 1.00
joel_test_score_test.rb に関しては、リファクタリング終了