Project

General

Profile

Actions
Copy link

Code Review #420

closed

reek の指摘に従い、リファクタリング

Added by Takashi Takebayashi over 14 years ago. Updated over 14 years ago.

Status:
終了（Closed）
Priority:
通常（Normal）
Assignee:
Takashi Takebayashi
Target version:
0.0.6
Start date:
06/01/2010
Due date:
% Done:

100%

Estimated time:
1:00 h
Spent time:
1:00 h

Description

test/unit/joel_test_score_test.rb -- 7 warnings:
JoelTestScoreTest#test_is_joel_test_scores_should_equal calls joel_test_scores(:joel_test_scores001) twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_equal calls joel_test_scores(:joel_test_scores001).user_id twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_equal calls joel_test_scores(:joel_test_scores003) twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_equal has approx 7 statements (LongMethod)
JoelTestScoreTest#test_is_joel_test_scores_should_equal has the variable name 'user1' (UncommunicativeName)
JoelTestScoreTest#test_is_joel_test_scores_should_return_not_nil calls joel_test_scores(:joel_test_scores001) twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_return_not_nil calls joel_test_scores(:joel_test_scores001).user_id twice (Duplication)

Actions
Copy link
 #1

Updated by Takashi Takebayashi over 14 years ago

  • Status changed from 担当（Assigned） to 終了（Closed）
  • % Done changed from 0 to 100
  • Estimated time set to 1:00 h

joel_test_score_test.rb に関しては、リファクタリング終了

Actions
Copy link

Also available in: Atom PDF