プロジェクト

全般

プロフィール

Defect #811

完了

In _reply.html.erb, show_detail method undefined

Fahrzin Hemmati さんが12年以上前に追加. 12年以上前に更新.

ステータス:
終了(Closed)
優先度:
通常(Normal)
担当者:
対象バージョン:
開始日:
2011/08/05
期日:
進捗率:

100%

予定工数:

説明

On a default install of redmine_code_review 0.4.3, on ChiliProject 2.1.1:

1. Create a code review on a file diff on any line.
2. Refresh the page and click on the code review to view it
3. A 500 page shows up with "MethodError" and "show_detail" undefined.

The problem is in app/views/code_review/_reply.html.erb:26 at

<%= show_detail(detail) %>

This is related to this change by chiliproject:

https://www.chiliproject.org/issues/539

Could redmine_code_review be updated to use render_detail appropriately? I can't replace show_detail with render_detail directly, nor do I know rails well enough to try much beyond '@journal.render_detail' and '@reply.render_detail'.

Haru Iida さんが12年以上前に更新

  • プロジェクトr-labs から Code Review に変更
  • ステータス新規(New) から 担当(Assigned) に変更
  • 担当者Haru Iida にセット

Haru Iida さんが12年以上前に更新

Fahrzin Hemmati wrote:

Could redmine_code_review be updated to use render_detail appropriately? I can't replace show_detail with render_detail directly, nor do I know rails well enough to try much beyond '@journal.render_detail' and '@reply.render_detail'.

I think Redmine hasn't render_detail. So I can't change the code. Sorry.

Fahrzin Hemmati さんが12年以上前に更新

What is the code that you would use in that template? You could put it behind an if statement that checks for render_detail so this would be compatible with both redmine and chiliproject.

Haru Iida さんが12年以上前に更新

  • ステータス担当(Assigned) から 終了(Closed) に変更
  • 対象バージョン0.4.6 にセット
  • 進捗率0 から 100 に変更

Fixed by Andreas Schuh.

他の形式にエクスポート: Atom PDF