r-labs » Code Review

I found something that may help resolving the problem.

The problem occurs on branches that are copied from somewhere else (par example from trunk) but not have commits afterwards. Example:

• create something in trunk, make some revisions to achieve some progress there.
• create copy of trunk to branches, par example to branches/01.00.01
• open some file in this newly created branch for reviewing. You will not see "Add review" pencil and thus you will not be able to make review on it.
• make some change in the branch (you may need to checkout a working copy of it to do this)
• commit the change
• reload the repository by selecting 'Repository' tab on the project menu.
• open the same file (or some other file, it does not matter) for reviewing. Wow, you will see the Add review pencil and this way you will be able to initiate code review.

Conclusion: A branch must have its own local history so as to be re-viewable by CodeReview plugin. If it is just copied and there is no additional commits in it the code review is not available.

I made these observations using Subversion. I don't know if this is related to Subversion only.

Ivan

Hi,

What does いつかやる version mean?

Ivan Cenov は書きました:

Hi,

What does いつかやる version mean?

いつかやる means unplanned.

In last few month, codes of Redmine around SCM were greatly changed and the changing is still goes on.
I can't catch up.
I'm waiting for the code around SCM will be stable.