Defect #685
完了
Cannot code-review branches.
Ivan Cenov さんが約13年前に追加.
ほぼ13年前に更新.
説明
Hello.
My configuration is Redmine 1.1.1 and Code review 0.3.1.
I use Subversion as SCM.
Our software process demands programmers to create branches from trunk specially for performing code reviews on them. We do not make code review on trunk.
I was surprised when saw that Code Review is allowed on trunk only but not on branches:
- When I open some file that is somewhere under trunk, Add review link is seen and thus Code Review is allowed.
- When I open some file that is somewhere under branches, there is no Add review link and this way Code Review cannot be initiated.
Is this by design or is some bug in the plugin?
Ivan
ファイル
- プロジェクト を r-labs から Code Review に変更
Thank you for reporting.
hmm. I can add review to branches.
I tested this in Firefox and IExplorer. Here is the image:
I found something that may help resolving the problem.
The problem occurs on branches that are copied from somewhere else (par example from trunk) but not have commits afterwards. Example:
- create something in trunk, make some revisions to achieve some progress there.
- create copy of trunk to branches, par example to branches/01.00.01
- open some file in this newly created branch for reviewing. You will not see "Add review" pencil and thus you will not be able to make review on it.
- make some change in the branch (you may need to checkout a working copy of it to do this)
- commit the change
- reload the repository by selecting 'Repository' tab on the project menu.
- open the same file (or some other file, it does not matter) for reviewing. Wow, you will see the Add review pencil and this way you will be able to initiate code review.
Conclusion: A branch must have its own local history so as to be re-viewable by CodeReview plugin. If it is just copied and there is no additional commits in it the code review is not available.
I made these observations using Subversion. I don't know if this is related to Subversion only.
Ivan
- ステータス を 新規（New） から 担当（Assigned） に変更
- 担当者 を Haru Iida にセット
- 対象バージョン を 0.4.1 にセット
Thanks. I will check my codes.
- 対象バージョン を 0.4.1 から いつかやる(Unplanned) に変更
Hi,
What does いつかやる version mean?
Ivan Cenov は書きました:
Hi,
What does いつかやる version mean?
いつかやる means unplanned.
In last few month, codes of Redmine around SCM were greatly changed and the changing is still goes on.
I can't catch up.
I'm waiting for the code around SCM will be stable.
- ステータス を 担当（Assigned） から 解決（Resolved） に変更
- 進捗率 を 0 から 100 に変更
更新履歴 commit:2a7584751bbc で適用されました。
- 対象バージョン を いつかやる(Unplanned) から 0.4.2 に変更
- ステータス を 解決（Resolved） から 終了（Closed） に変更
他の形式にエクスポート: Atom
PDF
