Defect #1345
closed
'Add Ticket' button no longer works with Chrome 37+
100%
Description
Since Chrome 37, the popup window method no longer works. It does still work in IE 11.
The same issue seems to be described here and may provide clues:
http://www.bugdebugzone.com/2014/08/sitecore-modal-pop-ups-are-not-working.html
Love worktime, and hope to have it still work in Chrome!
Thanks.
Files
Updated by Tomohisa Kusukawa over 10 years ago
- Status changed from 新規（New） to 担当（Assigned）
- Assignee set to Tomohisa Kusukawa
Thank you for your report.
I will consider how to respond.
Updated by Jamie Press over 10 years ago
Just some updates, as we searched for a workaround.
- Firefox 32 (latest) works properly.
- IE 11 works sometimes (occasionally opens a blank popup window)
Please note that our test case is ONLY the 'add ticket' button in Worktime.
Thanks.
Updated by Olivier Houdas over 10 years ago
- File wt-1345.patch wt-1345.patch added
The issue is due to Chrome 37 stopping to include showModalDialog() in its javascript engine.
You will find a patch attached with a way to fix the issue. It is not very elegant, as I had to work around the fact that the replacement function is not modal (asynchronous call) and therefore we need to split the functions in 2 : one part before the popup, and a second part executed after.
Updated by Tomohisa Kusukawa over 10 years ago
- Status changed from 担当（Assigned） to 解決（Resolved）
- % Done changed from 0 to 100
更新履歴 commit:ebafbdda1955 で適用されました。
Updated by Tomohisa Kusukawa over 10 years ago
Thank you very much for your report and especially patches.
I was considered variety,
The Ajax was desirable for usability of the future, maybe.
If you are available, please try following alpha version.
mercurial clone
https://tkusukawa@bitbucket.org/tkusukawa/redmine_work_time
download
https://bitbucket.org/tkusukawa/redmine_work_time/downloads
-> Branches tab -> #1345
Updated by Olivier Houdas over 10 years ago
It seems to work fine (tested only adding an issue and changing completion percentage). I tested on RM 2.5.2.
By the way, completion percentages are clickable even though Redmine's option is set to follow issues statuses (in that case, changing the value has no effect). It might make sense not to show a link if Issue.use_status_for_done_ratio? is true.
Updated by Tomohisa Kusukawa over 10 years ago
Certainly.
I modified at commit:8a1ae34
Thanks again!
Updated by Tomohisa Kusukawa over 10 years ago
更新履歴 commit:9ec9d92b7324 で適用されました。
Updated by Tomohisa Kusukawa over 10 years ago
- Status changed from 解決（Resolved） to 終了（Closed）
- Target version set to 0.2.16
Close branch and merge to default line. (repository)
Thank you.